[FFmpeg-devel] [PATCH V5 1/2] lavf/vc1test: fix vc1test can't probe some RCV file.

mypopy at gmail.com mypopy at gmail.com
Tue Oct 23 03:43:38 EEST 2018


On Tue, Oct 23, 2018 at 4:40 AM Michael Niedermayer
<michael at niedermayer.cc> wrote:
>
> On Wed, Oct 17, 2018 at 08:18:57AM +0800, Jun Zhao wrote:
> > case 1:
> > use the hexdump -C SMM0005.rcv get:
> >                      size              skip (size - 4)
> >                       |                        |
> >                       V                        V
> > 00000000  18 00 00 c5 05 00 00 00  4d f1 0a 11 00 e0 01 00
> > 00000010  00 d0 02 00 00 0c 00 00  00 88 13 00 00 c0 65 52
> >                          ^
> >                        |
> >                    size + 16
> > case 2:
> > same the command for SMM0015.rcv get:
> >                     size
> >                       |
> >                       V
> > 00000000  19 00 00 c5 04 00 00 00  41 f3 80 01 40 02 00 00
> > 00000010  d0 02 00 00 0c 00 00 00  00 00 00 10 00 00 00 00
> >                       ^
> >                     |
> >                  size + 16
> >
> > There are different the RCV file format for VC-1, vc1test
> > just handle the case 2 now, this fix will support the case 1.
> > (Both of test clips come from: SMPTE Recommended Practice -
> > VC-1 Decoder and Bitstream Conformance). And I think I got
> > a older VC-1 test clip in the case 1.
> >
> > Reviewed-by: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> > Reviewed-by: Jerome Borsboom <jerome.borsboom at carpalis.nl>
> > Reviewed-by: Michael Niedermayer <michael at niedermayer.cc>
> > Signed-off-by: Jun Zhao <jun.zhao at intel.com>
> > Signed-off-by: Yan, FengX <fengx.yan at intel.com>
> > ---
> >  libavformat/vc1test.c |   12 ++++++++++--
> >  1 files changed, 10 insertions(+), 2 deletions(-)
>
> can you add a fate test for this ?
>
> [...]
> --
Will update the fate test case with the test clips upload, Thanks.


More information about the ffmpeg-devel mailing list