[FFmpeg-devel] [PATCH] tests/checkasm/Makefile: fix 'make fate' error when enable vaapi

[Mark Thompson]

On 24/10/18 06:15, Zachary Zhou wrote:
> Reproduce the issue:
> 
> $ ./configure --enable-libmfx --enable-vaapi --enable-shared --samples=fate-suite/
> $ make fate
> LD	tests/checkasm/checkasm
> /usr/bin/x86_64-linux-gnu-ld: libavutil/libavutil.a(hwcontext_vaapi.o): undefined reference to symbol 'XDisplayName'
> //usr/lib/x86_64-linux-gnu/libX11.so.6: error adding symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> tests/checkasm/Makefile:71: recipe for target 'tests/checkasm/checkasm' failed
> make: *** [tests/checkasm/checkasm] Error 1
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index 85d5dd5962..f3e27cea10 100755
> --- a/configure
> +++ b/configure
> @@ -6387,6 +6387,7 @@ if enabled vaapi; then
>  
>      if enabled xlib; then
>          check_pkg_config vaapi_x11 "libva-x11" "va/va_x11.h" vaGetDisplay
> +        check_pkg_config vaapi_x11 "libX11" "X11/Xlib.h" XDisplayName
>      fi
>  
>      check_cpp_condition vaapi_1 "va/va.h" "VA_CHECK_VERSION(1, 0, 0)"
> 

This seems wrong - since xlib is enabled when you get here the xlib check on line 5891 should already have included the relevant X library options.

I think your build setup is incorrect somehow - note that to test a build with --enable-shared you need to either run the install (+ ldconfig) or pass a suitable LD_LIBRARY_PATH option.

Thanks,

- Mark