[FFmpeg-devel] [PATCH] add the protection for http range get request starting from file size

[Michael Niedermayer]

On Fri, Oct 26, 2018 at 06:40:53PM +0800, shenqichao wrote:
> Signed-off-by: shenqichao <qichaoshen at 163.com>
> ---
>  libavformat/http.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 3a35bc7eac..129f683d15 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -1669,7 +1669,7 @@ static int64_t http_seek_internal(URLContext *h, int64_t off, int whence, int fo
>      int old_buf_size, ret;
>      AVDictionary *options = NULL;
>  
> -    if (whence == AVSEEK_SIZE)
> +    if (whence == AVSEEK_SIZE || (whence == SEEK_SET && off == s->filesize))
>          return s->filesize;
>      else if (!force_reconnect &&
>               ((whence == SEEK_CUR && off == 0) ||

missing ticket number in commit message

also this doesnt feel correct.
a seek request to the previous file end must not lock up the http code
also the file may at the time of the request have a different size than before


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181026/4fca927f/attachment.sig>