[FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

Nicolas George george at nsup.org
Sat Oct 27 22:02:15 EEST 2018


James Almer (2018-10-27):
> > Not sure what compiler was warning about these, but it's definitely
> > incorrect for it to do so.  Maybe an old gcc?  Recent gcc should
> > have this fixed - see
> > <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119>.
> Clang seems to do it as well. See
> http://ffmpeg.org/pipermail/ffmpeg-devel/2018-October/235632.html
> 
> You could initialize it setting the three fields directly, or use a memset.

Or we could consider it's clang's responsibility to fix an incorrect
warning. And possibly people who care about developing ffmpeg with clang
to come up with a solution that does not make the code less readable and
harder to maintain.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181027/b9a22f4a/attachment.sig>


More information about the ffmpeg-devel mailing list