[FFmpeg-devel] [PATCH 1/2] libavutil: Undeprecate the AVFrame reordered_opaque field

[Derek Buitenhuis]

On 29/10/2018 20:10, Martin Storsjö wrote:
> Sorry, I think you've misunderstood this patch altogether.
> 
> It's not about reviving this field or not, it's all in full use
> already. It was never deprecated with any active plan to remove it, the
> only steps were a few doxygen comments, never any attributes that would
> actually prompt action.
> 
> And a few years later someone noticed that these doxygen comments didn't
> match up with reality, and it was decided (with no objections on either
> project) that these really shouldn't be deprecated as it is the only
> actual mechanism we have for doing exactly this.
> 
> It's just that the undeprecation commit, ad1ee5fa7, missed one field. And
> the one I'm removing the stray deprecation comment from, is the very
> properly placed one in AVFrame non the less.

Well, you're adding new code that uses it... which, in my mind is akin to
encouraging its use. But, yes, you're not technical undeprecating.

I'm kinda tempted to send a patch to actually deprecate it again, and
replace it with something less terrible. You've kinda shone a flashlight
on a particularily terrible (IMO) API, is all. Looking back at the list
where this was undeprecated, no real reasoning was given for keeping it
around in this form, AFAICT, and nobody asked either. It was kept because
it was effort to replace it, I guess.

I won't block the patch set, but will note that I object to continued
existence of such a terrible API, and adding new stuff that uses it.

- Derek