[FFmpeg-devel] [PATCH 2/2] libx264: Pass the reordered_opaque field through the encoder

[Martin Storsjö]

On Mon, 29 Oct 2018, Derek Buitenhuis wrote:

> On 25/10/2018 13:58, Martin Storsjö wrote:
>> +    x4->nb_reordered_opaque = x264_encoder_maximum_delayed_frames(x4->enc) + 1;
>
> Is it possible this changes when the encoder is reconfigured (e.g. to interlaced)?

Good point. I'm sure it's possible that it changes, if reconfiguring.

As I guess there can be old frames in flight, the only safe option is to 
enlarge, not to shrink it. But in case a realloc moves the array, the old 
pointers end up pretty useless.

Tricky, I guess I'll have to think about it to see if I can come up with 
something which isn't completely terrible.

// Martin