[FFmpeg-devel] [PATCH v2] fate/api-h264-slice-test: use cleaner error handling

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Oct 29 23:16:56 EET 2018


2018-10-29 15:49 GMT+01:00, joshdk at ob-encoder.com <joshdk at ob-encoder.com>:

>      while(1) {
>          uint16_t size = 0;
> -        ssize_t ret = fread(&size, 1, sizeof(uint16_t), fd);
> -        if (ret < 0) {
> -            perror("Couldn't read size");
> -            exit(1);
> -        } else if (ret != sizeof(uint16_t))
> +        size_t ret = fread(&size, 1, sizeof(uint16_t), file);
> +        if (ret != sizeof(uint16_t))

I didn't see this originally because it is a little to well hidden.

Please split this out and mention ticket #7521.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list