[FFmpeg-devel] [PATCH] Revert "lavc/v4l2_m2m_enc: Add missing braces around initializers."

[Carl Eugen Hoyos]

2018-10-31 1:07 GMT+01:00, Ronak Patel <ronak2121-at-yahoo.com at ffmpeg.org>:
>
>> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>> 2018-10-27 20:50 GMT+02:00, Mark Thompson <sw at jkqxz.net>:
>>> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df.
>>>
>>> The additional braces cause build errors with Linux headers earlier
>>> than 4.5 because the first element of the structure was not originally
>>> a union.
>>
>>> Not sure what compiler was warning about these, but it's definitely
>>> incorrect for it to do so.
>>
>> Must have been NDK clang.
>
> This fix isn’t enough for this. The references to the variables
> in the union fail to compile. This doesn’t fix that.

In that case adding a configure check that disables the feature
for such headers may be the simpler solution.

Carl Eugen