[FFmpeg-devel] [PATCH] frame: Simplify the video allocation

Michael Niedermayer michael at niedermayer.cc
Mon Sep 3 11:17:34 EEST 2018


On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote:
> From: Luca Barbato <lu_zero at gentoo.org>
> 
> Merged-by: James Almer <jamrial at gmail.com>
> ---
> This is the next merge in the queue. It's a critical part of the AVFrame API,
> so even if FATE passes I'd rather have others look at it and test in case
> something breaks.
> 
> The only difference compared to the libav commit is the "32 - 1" padding per
> plane when allocating the buffer, which was only in our tree.

why is the STRIDE_ALIGN (which is a thing in units of bytes along the
horizontal axis) added to padded_height which is vertical axis ?
This is not done prior to the change

Also if this changes how buffers are structured or sized it requires a more
detailed commit message than "frame: Simplify the video allocation"

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180903/26a7eb57/attachment.sig>


More information about the ffmpeg-devel mailing list