[FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter
timo at rothenpieler.org
Mon Sep 3 13:42:33 EEST 2018
Minus the missing configure dependency, documentation entry and minor
bump, the filter looks fine to me code wise.
Two issues though:
From my understanding, it's not a transpose filter, but a rotation one,
fixed to 90 degree angles. Unless I'm missing something in the code,
it's not doing any actual flipping, like vf_transpose does.
It should also be calling nppiTranspose_8u_C1R somewhere after/before
the call to nppiRotate_8u_C1R. Or use a transformation matrix to do the
transposition in one step, assuming libnpp has a function for that.
It's possible that I missed it doing the transpose somewhere, so please
correct me if I'm wrong.
I'd also strongly prefer this filter to be compatible with the arguments
of normal vf_transpose, and behave the same for the same arguments.
Additional parameters with more functions are fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4538 bytes
Desc: S/MIME Cryptographic Signature
More information about the ffmpeg-devel