[FFmpeg-devel] [PATCH] Revert "avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

Hendrik Leppkes h.leppkes at gmail.com
Thu Sep 13 00:44:44 EEST 2018

On Wed, Sep 12, 2018 at 8:15 PM James Almer <jamrial at gmail.com> wrote:
> This reverts commit f631c328e680a3dd491936b92f69970c20cdcfc7.
> The avcodec_parameters_to_context() call was freeing and reallocating
> AVCodecContext->extradata, essentially taking ownership of it, which according
> to the doxy is user owned. This is an API break and has produces crashes in
> some library users like Firefox[1].
> Revert until a better solution is found to internally propagate the filtered
> extradata back into the decoder context.
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1486080

This is not the only place where extradata is being
free'ed/re-allocated by avcodec during decoding, which is why I
recommended the documentation change when it came up.

At least this one place is one I know of, maybe there are more:

- Hendrik

More information about the ffmpeg-devel mailing list