[FFmpeg-devel] [PATCH] Revert "avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

Timo Rothenpieler timo at rothenpieler.org
Thu Sep 13 12:50:59 EEST 2018

> So, what do we do now? Honor the doxy and stop trying to manipulate
> what's meant to be an user owned pointer/buffer, officially break the
> API and declare it's meant to be allocated by the user but then
> ownership is passed to the library during or after the avcodec_open2()
> call, or just revert this commit and pretend nothing happened?

Documenting the API break that already happened seems like the least bad 
option right now. Firefox already merged code to work around the crash.

It already is freed in multiple places, so existing code probably 
already is compatible.

No solution to this is overly pretty unfortunately.
Specially as this goes along with likely leaking the extradata pointer, 
as unconditionally freeing it will most definitely cause crashes left 
and right.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4538 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180913/fa59fcf8/attachment.bin>

More information about the ffmpeg-devel mailing list