[FFmpeg-devel] [PATCH] lavc/mpeg2dec: fix MPEG2 VA-API interlace decoding issue.

mypopy at gmail.com mypopy at gmail.com
Thu Sep 20 03:43:10 EEST 2018


On Mon, Sep 17, 2018 at 8:00 PM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>
> On Mon, Sep 17, 2018 at 1:22 PM Jun Zhao <mypopydev at gmail.com> wrote:
> >
> > From: Jun Zhao <jun.zhao at intel.com>
> >
> > For interlaced frame, it has to call slice_end() for both fields. And
> > VASliceParameterBufferMPEG2::slice_vertical_position is supposed to be
> > the position in the picture but not field in this case.
> >
>
> How does this impact other hwaccels or software decoding? Because
> those cases seem to be working just fine the way it is now, from what
> I can tell.
After double-check the coding logic, I think we don't need to change
mpeg12dec.c, will update V2 patch.
>
> Also, in the VA-API calling code, are you setting avctx->slice_flags
> to SLICE_FLAG_ALLOW_FIELD? Because that forces an end_frame call for
> every field, which may be all that is needed here.
>
> - Hendrik
And we are not setting SLICE_FLAG_ALLOW_FIELD in this case, this is a good
suggestion for me, will try this way.

Thanks.


More information about the ffmpeg-devel mailing list