[FFmpeg-devel] [PATCH V2] ffmpeg: fix video_delay warning for HEVC/MPEG4 decoding

[Michael Niedermayer]

On Wed, Sep 26, 2018 at 06:03:19PM +0800, Jun Zhao wrote:
> For HEVC/MPEG4, we also need video_delay from the decoder, when decoding
> some HEVC/MPEG4 clips, got numerous log like:
> "video_delay is larger in decoder than demuxer", similar ticket: #3711

for mpeg4 this looks incorrect. 

What your patch does is simply override the "demuxer side" but the patch
never explains why this would be the correct solution or why the demuxer
side gets the value wrong

Obviously if something (like the "demuxer side") gets a value wrong the
obvious solution is to fix that. For H264 determining the delay is rather
hard in some corner cases (as a result of the field that would signal the
delay being optional and not available in all streams) 

So please either fix the code that is responsible for this being set
wrong in mpeg4 or explain why we should hack around it instead of
fixing it.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180926/46a0e8e9/attachment.sig>