[FFmpeg-devel] [PATCH] avformat: add H264 and HEVC support in IVF muxer

Nicolas George george at nsup.org
Sun Sep 30 23:48:29 EEST 2018


Paul B Mahol (2018-09-30):
> > For consistency within a single function, an assert is the correct
> > choice.
> No, it is not. Asserts do not add any consistency.

Asserts do not add consistency indeed. Their purpose is to check
consistency, which is exactly what needs testing here: the consistency
between the preliminary test and the later switch statement.

If you want to argue for AVERROR_BUG, please give arguments.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180930/f5765995/attachment.sig>


More information about the ffmpeg-devel mailing list