[FFmpeg-devel] [PATCH 10/15] avformat/matroskaenc: Avoid seeking when writing level 1 elements

[Andreas Rheinhardt]

Hendrik Leppkes:
> On Tue, Apr 2, 2019 at 3:36 PM Andreas Rheinhardt via ffmpeg-devel
> <ffmpeg-devel at ffmpeg.org> wrote:
>> @@ -383,8 +388,8 @@ static void end_ebml_master_crc32_preliminary(AVIOContext *pb, AVIOContext **dyn
>>          uint8_t *buf;
>>          int size = avio_get_dyn_buf(*dyn_cp, &buf);
>>
>> +    put_ebml_num(pb, size, master.sizebytes);
>>          avio_write(pb, buf, size);
>> -        end_ebml_master(pb, master);
>>  }
>>
> 
> The indent here seems off, or did my mail client mangle something?
> 
In patch 8 I removed a redundant check in
end_ebml_master_crc32_preliminary, but I did not change indentation
(that's done in patch #12). So put_ebml_num is written at the level of
indentation that the rest will be after the indentation will have been
fixed in #12.
(Alternatively, one could write put_ebml_num one indentation level too
high and shift it to the left in #12.)

- Andreas