[FFmpeg-devel] [PATCH] Patch for memory optimization with QuickTime/MP4
Joerg.Beckmann at scisys.com
Mon Dec 2 12:55:55 EET 2019
You cannot discard whatever is possible AND also try to seek. If you want to seek, you must not use this option. Even if I did not manage to create an example where switch root was called while reading from a file, I'm not sure that it is really impossible. And if switch root is called and the option is set, there is nothing left to search in. Therefore I believe that seeking shall not be allowed if the option is set. If someone stands up and declares that this cannot happen, we can remove the if from the seek. Obviously, there is some more documentation needed. I'll write some as soon as we agree on what to document.
I'll use assert() instead of the if and the warning.
Von: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> Im Auftrag von Carl Eugen Hoyos
Gesendet: Montag, 2. Dezember 2019 11:29
An: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
Betreff: [SCISYS Possible Spam] Re: [FFmpeg-devel] [SCISYS Possible Spam] Re: [PATCH] Patch for memory optimization with QuickTime/MP4
Am Mo., 2. Dez. 2019 um 11:06 Uhr schrieb Jörg Beckmann
<Joerg.Beckmann at scisys.com>:
> The for-loop and the warning are copied from somewhere else in the decoder. I'm also quite sure that it cannot really happen.
Then use an assert().
> One cannot set the option to discard old frames and also try to seek. I did not manage to create an example with calls to switch_root while reading from a file. But if it is possible somehow and the option is set, there are no old fragments to seek in. Therefore I think, seek should be forbidden if the option is set.
But if you read from a file and use the option, seeking does not work although it would be possible or do I misunderstand?
Please find out what top-posting means and avoid it here.
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
More information about the ffmpeg-devel