[FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

James Almer jamrial at gmail.com
Tue Dec 3 14:10:37 EET 2019

On 12/3/2019 5:20 AM, Carl Eugen Hoyos wrote:
> Am Mo., 2. Dez. 2019 um 17:19 Uhr schrieb James Almer <jamrial at gmail.com>:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> This is meant to be squashed with patch 2/3, otherwise it will write duplicate
>> compatible brands, and a lot of tests will have to be updated twice.
>> I'm sending it like this to make reviewing/reading easier.
> Could you add a line about why writing the major brand as compatible
> brand is a good idea? Is this recommended or does it fix a player?
> Thank you, Carl Eugen

The DASH IF validator complains about it when the major isn't listed
again as a compatible brand.
We're already writing the major a second time in some specific cases.
See the checks for mov, psp and 3gp I'm removing at the end of this
patch. For mp4 it depended on a magic combination of options. I'm just
making it cleaner and more general.

There's also ticket 8375 which may or may not be fixed by this.

More information about the ffmpeg-devel mailing list