[FFmpeg-devel] [PATCHv2 2/2] checkasm: float_dsp: Scale FLT/DBL_EPSILON sufficiently when comparing

Michael Niedermayer michael at niedermayer.cc
Wed Dec 11 16:55:19 EET 2019


On Wed, Dec 11, 2019 at 11:21:14AM +0200, Martin Storsjö wrote:
> As the values generated by av_bmg_get can be arbitrarily large
> (only the stddev is specified), we can't use a fixed tolerance.
> 
> This matches what was done for test_vector_dmul_scalar in
> 38f966b2222db.
> 
> This fixes the float_dsp checkasm test for some seeds, when built
> with clang for mingw/x86_32.
> ---
> Tweaked the form of the tolerance to match the existing case, removed
> unnecessarily wordy comments.
> ---
>  tests/checkasm/float_dsp.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

LGTM

thx


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191211/26eddbd8/attachment.sig>


More information about the ffmpeg-devel mailing list