[FFmpeg-devel] [PATCH 3/3] ffprobe: Fix fate tests for ffprobe in cases where TARGET_PATH differs from the current path

James Almer jamrial at gmail.com
Wed Dec 18 02:10:56 EET 2019

On 12/17/2019 6:27 PM, Martin Storsjö wrote:
> On Sun, 15 Dec 2019, Martin Storsjö wrote:
>> On Tue, 10 Dec 2019, Martin Storsjö wrote:
>>> In these cases, we must pass the full path of the file to ffprobe
>>> (as the current working dir on the remote system, e.g. when invoked
>>> with "ssh remote ffprobe ..." isn't the wanted one).
>>> The input filename passed to ffprobe is also included in the output,
>>> which is part of the reference test data. Add a new option to
>>> ffprobe to allow overriding what path is printed, to keep the
>>> original relative path in the tests.
>>> An alternative approach could be an option to allow requesting omitting
>>> the file name from the dumped data, and updating the test references
>>> accordingly.
>>> ---
>>> fftools/ffprobe.c      | 22 ++++++++++++++++++----
>>> tests/fate/ffprobe.mak |  2 +-
>>> 2 files changed, 19 insertions(+), 5 deletions(-)
>> Ping
> If there's no opposition to this one, I'll push it tomorrow; it's been out
> for review for over a week.
> // Martin

Not against it, but there have been a couple new tests since you first
sent this, so better check they don't break, or require changes.

More information about the ffmpeg-devel mailing list