[FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

Nicolas George george at nsup.org
Mon Dec 23 11:00:41 EET 2019


Limin Wang (12019-12-23):
> But It's not my code, I'm a code reviewer.

Then review that ret needs to be returned ;-) It needs more change, not
less.

And the commit message needs to be explicit. CID may not be available
everywhere or everywhen.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191223/e399b756/attachment.sig>


More information about the ffmpeg-devel mailing list