[FFmpeg-devel] [PATCH] lavfi: add mbfequalizer filter.

Nicolas George george at nsup.org
Mon Dec 23 15:25:09 EET 2019

Thanks for the comment.

James Almer (12019-12-23):
> > +        frame_out = ff_get_audio_buffer(ctx->outputs[0], frame->nb_samples);

> Can't you use av_frame_make_writable() instead to simplify this?

No, because it does not use ff_get_audio_buffer(), and therefore does
not allow direct rendering. Also, it unnecessarily copies the data. I
have already noted that this is a frequent pattern in filters that
should be factored soon.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191223/b9be805f/attachment.sig>

More information about the ffmpeg-devel mailing list