[FFmpeg-devel] [PATCH] avfilter/buffersrc: remove redundant flag

Nicolas George george at nsup.org
Mon Dec 23 18:18:53 EET 2019


quinkblack at foxmail.com (12019-12-04):
> From: Zhao Zhili <zhilizhao at tencent.com>
> 
> !(c->pix_fmt != AV_PIX_FMT_NONE || c->got_format_from_params)
> 
> equals
> 
> (c->pix_fmt == AV_PIX_FMT_NONE) && !c->got_format_from_params
> 
> 1. When (c->pix_fmt == AV_PIX_FMT_NONE) is true, got_format_from_params is
> always false, the flag doesn't contribute to the result.
> 
> 2. When the first part is false, the second part doesn't matter, the flag
> doesn't contribute to the result.
> 
> The result only depends on c->pix_fmt.
> ---
>  libavfilter/buffersrc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Well spotted. Pushed. Thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191223/43581c78/attachment.sig>


More information about the ffmpeg-devel mailing list