[FFmpeg-devel] [PATCH 01/23] avformat/matroskaenc: Fix ReferenceBlock timestamp

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Dec 24 16:45:00 EET 2019

James Almer:
> On 12/24/2019 10:00 AM, Andreas Rheinhardt wrote:
>> I have just found out that the webm_chunk muxer takes lots of
>> liberties with our API: It does not use the typical API muxing
>> functions (avformat_write_header etc.), but instead calls the function
>> pointers on its own (is this even legal outside of mux.c?). webm_chunk
>> has been written at a time when init and deinit did not exist yet, so
>> they are never called. This wasn't really a problem until the Matroska
>> muxer switched to using an explicit deinit function in 982a98a0. Now
>> there is a memleak. And if this patchset got merged now, it would
>> absolutely break the webm_chunk muxer, because it moves several
>> allocations to the init function. So the webm_chunk muxer needs to be
>> fixed first.
> Who's the maintainer for it? He should be CC'd.

MAINTAINERS doesn't contain an entry for it, but the creator is
Vignesh Venkatasubramanian (vigneshv at google.com). I added him as a cc
to this very mail*. But I don't know whether he still works at google
and reads mails for this address.

- Andreas

*: The patchset that is referred to in the above quote is this:
Starting with the "Use random TrackUID" patch several allocations are
moved to the init function and would no longer be called by
webm_chunk; this would break the webm_chunk muxer.

More information about the ffmpeg-devel mailing list