[FFmpeg-devel] [PATCH] avfilter: add thistogram video filter

Nicolas George george at nsup.org
Thu Dec 26 21:18:29 EET 2019

Paul B Mahol (12019-12-26):
> Also there is bunch of all small different changes in code, which
> conflict more with your proposal.

I had looked at the code before making my comment: a significant part is
exactly identical or only differs by the name of the variable.

The rest can be handled with conditional and variables, I trust your
skill for that.

But as it is, there is way too much code duplication: any fix or
enhancement made to one of the filter will have to be done to the other,
which is in practice unlikely, and we will end up with two filters with
slightly different user interface and features. This is terrible for
user experience.

  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191226/e78faa43/attachment.sig>

More information about the ffmpeg-devel mailing list