[FFmpeg-devel] [PATCH] avformat/ftp: Exit with error on ftp_open if file does not exist

[Michael Niedermayer]

On Sat, Dec 28, 2019 at 04:11:54PM +0300, Fotyev V. wrote:
> See attached
> 
> On 2019-12-28 17:17, Michael Niedermayer wrote:
> >On Sat, Dec 28, 2019 at 01:52:04PM +0300, Fotyev V. wrote:
> >>Add a check for code 550 when requesting file size
> >>---
> >>  libavformat/ftp.c | 11 +++++++++--
> >>  1 file changed, 9 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/libavformat/ftp.c b/libavformat/ftp.c
> >>index 97ad80d..64a5250 100644
> >>--- a/libavformat/ftp.c
> >>+++ b/libavformat/ftp.c
> >>@@ -391,13 +391,17 @@ static int ftp_file_size(FTPContext *s)
> >>      char command[CONTROL_BUFFER_SIZE];
> >>      char *res = NULL;
> >>      static const int size_codes[] = {213, 0};
> >>+    int resp_code;
> >>
> >>      snprintf(command, sizeof(command), "SIZE %s\r\n", s->path);
> >>-    if (ftp_send_command(s, command, size_codes, &res) == 213 && res &&
> >>strlen(res) > 4) {
> >>+    resp_code = ftp_send_command(s, command, size_codes, &res);
> >patch is corrupted by newlines
> >
> >[...]
> >
> >thx
> >
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel at ffmpeg.org
> >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> >To unsubscribe, visit link above, or email
> >ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

>  ftp.c |   11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> c28f647f77a69ca7d24024277a89e52160dc642d  0001-libavformat-ftp-Exit-with-error-on-ftp_open-if-file-.patch
> From 46108143e535962dd2d65398e7f794cbeb3e9cd7 Mon Sep 17 00:00:00 2001

> From: ftk <ftk at users.noreply.github.com>

You may want to put your name in the author field, as this would be what ends
in git as author

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20191229/1a0056f7/attachment.sig>