[FFmpeg-devel] [PATCH 1/4 v2] avcodec/libx265: apply some global AVCodecContext settings to the encoder context

[Derek Buitenhuis]

On 30/12/2019 19:20, James Almer wrote:
> +    if (ctx->api->param_parse(ctx->params, key, buf) == X265_PARAM_BAD_VALUE) {
> +        av_log(avctx, AV_LOG_ERROR, "Invalid value %d for param \"%s\".\n", value, key);
> +        return AVERROR(EINVAL);
> +    }

Does returning error make sense here (soft fail)?

Code LGTM.

- Derek