[FFmpeg-devel] [PATCH] avcodec/libx264: support BGRA pixel format

[Thomas Volkert]

On 02.02.2019 16:18, Jan Ekström wrote:
> On Sat, Feb 2, 2019 at 5:14 PM Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2019-02-02 16:05 GMT+01:00, Thomas Volkert <silvo at gmx.net>:
>>> From: Thomas Volkert <thomas.volkert at net-zeal.com>
>>>
>>> ---
>>>  libavcodec/libx264.c | 15 ++++++++-------
>>>  1 file changed, 8 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
>>> index a3493f393d..dd51fdc6dc 100644
>>> --- a/libavcodec/libx264.c
>>> +++ b/libavcodec/libx264.c
>>> @@ -158,6 +158,9 @@ static int encode_nals(AVCodecContext *ctx, AVPacket
>>> *pkt,
>>>  static int avfmt2_num_planes(int avfmt)
>>>  {
>>>      switch (avfmt) {
>>> +    case AV_PIX_FMT_BGRA:
>> I was / am completely convinced that libx264 does not
>> support AV_PIX_FMT_BGRA.
>> Why do you believe it does / when was support added?
> It seems to support BGRA planes, of which it will only utilize BGR (as
> there is no fourth plane in H.264 as far as I can tell).

I was digging in the code of libx264 now. I think you are right - only 3
planes are used in case of AV_PIX_FMT_BGRA.


> Might want to add a warning that the alpha will be completely ignored
> if this pix_fmt is added as supported.

I changed my opinion - I would rather drop this patch.
Thanks for the feedback.

Best regards,
Thomas.