[FFmpeg-devel] [PATCH] configure: request explicitly enabled components

[Carl Eugen Hoyos]

2019-01-28 2:00 GMT+01:00, Marton Balint <cus at passwd.hu>:
> If we enable a component but a dependant library is disabled, then the
> enabled
> component get silently disabled. Requesting all explicitly enabled
> components
> allows configure to fail and show the missing dependencies instead of
> ignoring
> our request.
>
> For example if libdav1d is not availble ./configure
> --enable-decoder=libdav1d
> succeeds but the libdav1d decoder will not be enabled. After the patch the
> configure line will fail with the following message:
> ERROR: libdav1d_decoder requested, but not all dependencies are satisfied:
> libdav1d
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index e1412352fa..1f6c6a7311 100755
> --- a/configure
> +++ b/configure
> @@ -3881,6 +3881,7 @@ for opt do
>              list=$(filter "$name" $list)
>              [ "$list" = "" ] && warn "Option $opt did not match anything"
>              $action $list

> +            test $action = enable && request $list

I strongly suspect that this will break regression tests.

What exactly does this fix?
If you don't "--enable-libdav1d", you cannot get libdav1d.
Also, configure's console output shows what was
enabled.

I am not happy with this patch, sorry, Carl Eugen