[FFmpeg-devel] [PATCH]lavf/mpegts: Do not print the character coding as part of service name

Marton Balint cus at passwd.hu
Thu Feb 7 22:40:00 EET 2019



On Thu, 7 Feb 2019, Carl Eugen Hoyos wrote:

> 2019-02-07 16:34 GMT+01:00, Moritz Barsnick <barsnick at gmx.net>:
>> On Thu, Feb 07, 2019 at 14:40:40 +0100, Carl Eugen Hoyos wrote:
>>> +    if (p[0] < 0x20) {
>>> +        p++;
>>> +        if (--len < 0)
>>> +            return NULL;
>>> +    }
>>
>> If I understand section "A.2 Selection of character table" of ETSI EN
>> 300 468 correctly, you need to drop an additional byte if the first
>> byte (p[0]) is 0x1F, or an additional two bytes if the first one is
>> 0x10.
>
> New patch attached.

Don't simply drop charset information. You should convert the strings to 
UTF-8 based on that. Mpegts encoding needs updating too to be able to keep 
the international characters in case of stream copy...

Thanks,
Marton


More information about the ffmpeg-devel mailing list