[FFmpeg-devel] [PATCH 1/2 v3] add libaribb24 ARIB STD-B24 caption decoder

Jan Ekström jeebjp at gmail.com
Sun Feb 10 03:47:36 EET 2019


Noticed some minor issues while doing my final check-up of the patch
set, which I fixed locally. Checked that the configure checks still
failed if you tried to enable libaribb24 without version3, and that if
the version of the library is old enough, it would fail without gpl
being enabled.

On Sun, Feb 3, 2019 at 9:38 PM Jan Ekström <jeebjp at gmail.com> wrote:
> @@ -1684,6 +1685,7 @@ EXTERNAL_LIBRARY_NONFREE_LIST="
>  EXTERNAL_LIBRARY_VERSION3_LIST="
>      gmp
>      liblensfun
> +    libaribb24
>      libopencore_amrnb
>      libopencore_amrwb
>      libvmaf

Moved libaribb24 above liblensfun to be in alphabetical order. Wonder
why I missed this originally.

> @@ -1707,6 +1709,7 @@ EXTERNAL_LIBRARY_LIST="
>      jni
>      ladspa
>      libaom
> +    libaribb24
>      libass
>      libbluray
>      libbs2b

Hadn't noticed that EXTERNAL_LIBRARY_VERSION3_LIST was included in
this list at first, removed the duplicate entry.

All in all the changes are as follows :
diff --git a/configure b/configure
index cb852c6289..fe45fd2290 100755
--- a/configure
+++ b/configure
@@ -1684,8 +1684,8 @@ EXTERNAL_LIBRARY_NONFREE_LIST="

 EXTERNAL_LIBRARY_VERSION3_LIST="
     gmp
-    liblensfun
     libaribb24
+    liblensfun
     libopencore_amrnb
     libopencore_amrwb
     libvmaf
@@ -1709,7 +1709,6 @@ EXTERNAL_LIBRARY_LIST="
     jni
     ladspa
     libaom
-    libaribb24
     libass
     libbluray
     libbs2b

Jan


More information about the ffmpeg-devel mailing list