[FFmpeg-devel] [PATCH] avcodec/cbs_av1: change the assert in trailing_bits to accept zero bits when reading

Vittorio Giovara vittorio.giovara at gmail.com
Wed Feb 13 23:38:20 EET 2019


On Sun, Feb 10, 2019 at 3:12 PM James Almer <jamrial at gmail.com> wrote:

> If nb_bits is zero when reading an OBU, then it's not a bug in CBS but an
> invalid bitstream, and we should abort gracefully instead.
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> rav1e is currently encoding invalid Metadata OBUs without trailing bits,
> which
> are triggering the assert when parsed by CBS. This change makes sure to
> instead
> report the bitstream as invalid and gracefully return with an error code
> instead of crashing.
>

In case anyone is interested, this got fixed tonight, rav1e can produce
conformant bitstreams when encoding metadata now.
-- 
Vittorio


More information about the ffmpeg-devel mailing list