[FFmpeg-devel] [PATCH] avformat:matroskadec: use a define to mark the EBML length is unknown

Michael Niedermayer michael at niedermayer.cc
Sun Feb 24 14:55:22 EET 2019


On Sun, Feb 24, 2019 at 09:23:48AM +0100, Steve Lhomme wrote:
> On 23/02/2019 19:37, Michael Niedermayer wrote:
> >On Sat, Feb 23, 2019 at 11:14:33AM +0100, Steve Lhomme wrote:
> >>From: Steve Lhomme <robux4 at ycbcr.xyz>
> >>
> >>---
> >>  libavformat/matroskadec.c | 12 +++++++-----
> >>  1 file changed, 7 insertions(+), 5 deletions(-)
> >I think the commit message is a bit terse. This is not just a cosmetic
> >change (which one might think from reading just the commit message and
> >not looking at the change or related mails)
> >
> >Can you provide a more verbose commit message ?
> >ill apply it with that
> >
> >thanks
> >
> >[...]
> 
> How about this ?
> 
> "
> avformat:matroskadec: use a define to mark the EBML length is unknown
> 
> Unifying the way the EBML unknown length is signaled, rather than using two
> incompatible values. UINT64_MAX cannot be read as a valid EBML length with
> the
> current code.
> 
> Co-authored-by: Steve Lhomme <robux4 at ycbcr.xyz>
> Co-authored-by: Dale Curtis <dalecurtis at chromium.org>
> 
> "

will apply with this as commit message

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190224/c8caca75/attachment.sig>


More information about the ffmpeg-devel mailing list