[FFmpeg-devel] [PATCH V5 1/2] avutil: add ROI (Region Of Interest) data struct and bump version

[Vittorio Giovara]

On Fri, Jan 4, 2019 at 12:22 PM Nicolas George <george at nsup.org> wrote:

> Rostislav Pehlivanov (12019-01-04):
> > > +typedef struct AVRegionOfInterest {
> > > +    size_t self_size;
> > > +    size_t top;
> > > +    size_t bottom;
> > > +    size_t left;
> > > +    size_t right;
> > I'd still much rather have uints with fixed sizes than these platform
> > dependent types.
>
> Guo, Yejun said:
>
> >> I usually choose 'size_t' for the meanings with length/size.
>
> But that is a mistake. size_t is for length/size of objects in memory,
> not any length/size.
>
> These numbers, unless I am mistaken, are coordinates within an AVFrame.
> In that case, the only correct type is the same as AVFrame.width and
> AVFrame.height.
>

I personally disagree, what are coordinates within an AVFrame if not the
length/size of an object in memory?
A buffer containing video data is still an object in memory after all, so
IMHO using size_t makes a lot of sense here.
-- 
Vittorio