[FFmpeg-devel] [PATCH v2] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

Rostislav Pehlivanov atomnuker at gmail.com
Tue Jan 15 15:43:54 EET 2019


On Tue, 15 Jan 2019 at 11:57, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:

> 2019-01-15 11:30 GMT+01:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
> > On Tue, 15 Jan 2019 at 09:24, Shaofei Wang <shaofei.wang at intel.com>
> wrote:
>
> >> +#if HAVE_THREADS
> >> +        if (!abr_pipeline) {
> >> +            ret = reap_filters(1);
> >> +        } else {
> >> +            ret = pipeline_reap_filters(1, ifilter);
> >> +        }
> >>
> >
> > Same.
>
> This hunk should have brackets, it simplifies
> debugging and future patches at very little cost.
>

No, it does not. It wastes a line.


> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


More information about the ffmpeg-devel mailing list