[FFmpeg-devel] [PATCH] avformat/hcom: Fix "set but not used" warnings
Michael Niedermayer
michael at niedermayer.cc
Sun Jan 20 00:54:23 EET 2019
On Sat, Jan 19, 2019 at 04:11:07PM -0300, James Almer wrote:
> On 1/19/2019 4:08 PM, Michael Niedermayer wrote:
> > On Sat, Jan 19, 2019 at 03:53:55PM -0300, James Almer wrote:
> >> On 1/19/2019 3:50 PM, Michael Niedermayer wrote:
> >>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >>> ---
> >>> libavformat/hcom.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavformat/hcom.c b/libavformat/hcom.c
> >>> index 35515cc5b2..6d3d726fa5 100644
> >>> --- a/libavformat/hcom.c
> >>> +++ b/libavformat/hcom.c
> >>> @@ -38,7 +38,7 @@ static int hcom_probe(AVProbeData *p)
> >>> static int hcom_read_header(AVFormatContext *s)
> >>> {
> >>> AVStream *st;
> >>> - unsigned data_size, rsrc_size, huffcount;
> >>> + av_unused unsigned data_size, rsrc_size, huffcount;
> >>> unsigned compresstype, divisor;
> >>> unsigned dict_entries;
> >>> int ret;
> >>
> >> No, they should be removed and the relevant avio_rb32() replaced with
> >> avio_skip() alongside a comment to document what those bytes represent.
> >
> > I thought there might be some future code or checks that will use these
> > but if thats not the case then sure i can remove them
> >
> > thx
>
> data_size could i guess be used to set stream duration,
where can i find hcom samples ?
do you have some URLs ?
(for testing such use of the field)
> but i doubt this
> demuxer will get much more development than what's already done.
maybe
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190119/89837279/attachment.sig>
More information about the ffmpeg-devel
mailing list