[FFmpeg-devel] [PATCH 1/2] configure: enable libvpx-vp9 encoder and decoder

[James Almer]

On 3/4/2019 6:21 PM, Guo, Yejun wrote:
> currently run confingure and there is no "libvpx_vp9" for encoder and
> decoder in the output string, while "libvpx_vp8" is there.

The check is working fine as is on systems without pthreads, so the
commit message is wrong. It should say something like adding missing
pthreads extralibs dependency to it.

> 
> Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 3042ab9..1c0ba78 100755
> --- a/configure
> +++ b/configure
> @@ -6236,11 +6236,11 @@ enabled libvpx            && {
>      }
>      enabled libvpx_vp9_decoder && {
>          check_pkg_config libvpx_vp9_decoder "vpx >= 1.4.0" "vpx/vpx_decoder.h vpx/vp8dx.h" vpx_codec_vp9_dx ||
> -            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
> +            check_lib libvpx_vp9_decoder "vpx/vpx_decoder.h vpx/vp8dx.h" "vpx_codec_vp9_dx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"

$pthreads_extralibs, not -lpthread. the former will be set to the
correct ldflag depending on the host system.

>      }
>      enabled libvpx_vp9_encoder && {
>          check_pkg_config libvpx_vp9_encoder "vpx >= 1.4.0" "vpx/vpx_encoder.h vpx/vp8cx.h" vpx_codec_vp9_cx ||
> -            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs"
> +            check_lib libvpx_vp9_encoder "vpx/vpx_encoder.h vpx/vp8cx.h" "vpx_codec_vp9_cx VPX_IMG_FMT_HIGHBITDEPTH" "-lvpx $libm_extralibs -lpthread"
>      }
>      if disabled_all libvpx_vp8_decoder libvpx_vp9_decoder libvpx_vp8_encoder libvpx_vp9_encoder; then
>          die "libvpx enabled but no supported decoders found"
> 

LGTM otherwise.