[FFmpeg-devel] avcodec/vaapi_h264: skip decode if pic has no slices

[Peter F]

Thank you very much for your reply.
Am Sa., 9. März 2019 um 21:09 Uhr schrieb Jan Ekström <jeebjp at gmail.com>:

> > From 386c94489a86bb747b6531f727843cf259a24f5d Mon Sep 17 00:00:00 2001
> > From: xbmc <fernetmenta at online.de>
> Is this author field meant to not have an actual name in it? Just verifying.

It can stay as is. The original author sometimes uses fernetmenta /
xbmc depending on his
local git configuration. The email is unique though. I just
transported it upstream and fixed
the minors.

>
> > Date: Sat, 26 Jan 2019 19:48:35 +0100
> > Subject: [PATCH] avcodec/vaapi_h264: skip decode if pic has no slices
>
> Something along the lines of "avcodec/vaapi_h264: skip decoding if no
> slices were provided"?
>
> Also I would prefer if the reasoning for skipping decode on our layer
> would be explained in further lines of the commit message, like you
> have nicely explained it in the initial e-mail (to work-around a mesa
> vaapi driver bug).
> I don't remember the specifics of AVC, but are there valid VCL NAL
> units without slices (and would such end up in this code path to begin
> with)? I would guess that there would be no such valid VCL NAL units
> (or if there were, they wouldn't get to this point in the decode
> chain) - mostly just noting that this might be something we would like
> to check to verify if this should be an error or a "normal" state.
>
> The general idea I'm OK with since if we already know that there's no
> slices to decode, we might as well skip decoding as long as that
> doesn't cause issues with the state of the underlying
> libraries/drivers. Thus, I would mostly just wait for a reply from one
> of the VAAPI wrapper maintainers regarding if this skip should happen
> here or earlier in the decode process (where the buffers are being
> allocated).
>

Yes I would also like to hear a statement from these guys. Especially as
we (and most likely everyone else) just uses the ffmpeg send / receive API
without feeling the need to introduce VAAPI workarounds in this generic
application code

Thanks again, please find attached the updated version

Peter



-- 
                   Key-ID:     0x1A995A9B
                   keyserver: pgp.mit.edu
==============================================================
Fingerprint: 4606 DA19 EC2E 9A0B 0157  C81B DA07 CF63 1A99 5A9B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-vaapi_h264-skip-decode-if-pic-has-no-slices.patch
Type: text/x-patch
Size: 996 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190309/d947716a/attachment.bin>