[FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add mxf user comments tests

Tomas Härdin tjoppen at acc.umu.se
Mon Mar 11 23:51:56 EET 2019


mån 2019-03-11 klockan 13:22 -0700 skrev mindmark at gmail.com:
> From: Mark Reid <mindmark at gmail.com>
> 
> ---
>  tests/fate/mxf.mak                      | 15 ++++++++++++++-
>  tests/ref/fate/mxf-d10-user-comments    |  1 +
>  tests/ref/fate/mxf-opatom-user-comments |  1 +
>  tests/ref/fate/mxf-user-comments        |  1 +
>  4 files changed, 17 insertions(+), 1 deletion(-)
>  create mode 100644 tests/ref/fate/mxf-d10-user-comments
>  create mode 100644 tests/ref/fate/mxf-opatom-user-comments
>  create mode 100644 tests/ref/fate/mxf-user-comments
> 
> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
> index dce23d522e..62e4ec01cb 100644
> --- a/tests/fate/mxf.mak
> +++ b/tests/fate/mxf.mak
> @@ -37,9 +37,22 @@ FATE_MXF_REEL_NAME-$(call ENCDEC2, MPEG2VIDEO,
> PCM_S16LE, MXF) += fate-mxf-reel_
>  fate-mxf-reel_name: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
>  fate-mxf-reel_name: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-
> 00001.mxf  -c copy -timecode 00:00:00:00 -metadata
> "reel_name=test_reel" -fflags +bitexact -f mxf
>  
> +FATE_MXF_USER_COMMENTS-$(call ENCDEC2, MPEG2VIDEO, PCM_S16LE, MXF)
> += fate-mxf-user-comments
> +fate-mxf-user-comments: $(TARGET_SAMPLES)/mxf/Sony-00001.mxf
> +fate-mxf-user-comments: CMD = md5 -y -i $(TARGET_SAMPLES)/mxf/Sony-
> 00001.mxf -c copy -metadata "comment_test=value" -fflags +bitexact -f
> mxf

For a while I thought we could maybe make these tests faster by not
muxing any essence, but the opatom case wouldn't work, and maybe not
the others either. In short: looks OK to me.

/Tomas


More information about the ffmpeg-devel mailing list