[FFmpeg-devel] [PATCH 1/1] avcodec/aacenc: Validate and log bitrate changes made during encoding

[Rostislav Pehlivanov]

On Sat, 9 Mar 2019 at 12:56, Oliver Collyer <ovcollyer at mac.com> wrote:

> Although accenc appears able to cope with dynamic bitrate changes, this
> patch makes sure that any such changes are validated in the same manner as
> the initial bitrate and also adds logging of such changes in verbose mode.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


I think its better to leave the bitrate default bitrate setting in init,
remove the last_bit_rate variable entirely and always do limiting at the
start of the encode_frame function. Don't bother with printing out bitrate
changes, users can assume the encoder will start using it.