[FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

Henrik Gramner henrik at gramner.com
Thu Mar 14 03:58:41 EET 2019


On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng
<maskray-at-google.com at ffmpeg.org> wrote:
> --- a/libavutil/mem.h
> +++ b/libavutil/mem.h
>
> +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__))
> +    #define DECLARE_HIDDEN __attribute__ ((visibility ("hidden")))
> +#else
> +    #define DECLARE_HIDDEN
> +#endif

libavutil/mem.h is a public header so any defines added should have
appropriate prefixes (yes, the existing defines violate this which is
something that should be addressed, but that's a different issue).

Alternatively maybe those macros should be moved to some internal
header because I don't really see any value of having inline asm
support macros public.


More information about the ffmpeg-devel mailing list