[FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

Ulf Zibis Ulf.Zibis at CoSoCo.de
Fri Mar 15 02:08:33 EET 2019


Am 11.03.19 um 23:29 schrieb Lou Logan:
> Commit message title prefix for filter patches are usually in the form
> of:
>
> avfilter/fillborders:
> or
> lavfi/fillborders: 
>
> Trailing whitespace. This should always be avoided.
>
> Use av_malloc.

I now have separted the changes into 4 patches, and mergerd your hints.

So you can clearly see, which calculations I have skipped or moved out
of inner for loops.
Can you give a rating if a performance win could be expected compaired
to the original code from your experienced knowledge without a benchmark?

-Ulf

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_commit_1.patch
Type: text/x-patch
Size: 12804 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/82572d25/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_commit_2.patch
Type: text/x-patch
Size: 11396 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/82572d25/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_commit_3.patch
Type: text/x-patch
Size: 13795 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/82572d25/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vf_fillborders_commit_4.patch
Type: text/x-patch
Size: 13778 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/82572d25/attachment-0003.bin>


More information about the ffmpeg-devel mailing list