[FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

[Vittorio Giovara]

On Fri, Mar 29, 2019 at 5:28 AM Jing Sun <jing.a.sun at intel.com> wrote:

> +static int config_enc_params(EB_H265_ENC_CONFIGURATION *param,
> +                             AVCodecContext *avctx)
> +{
> +    SvtContext *svt_enc = avctx->priv_data;
> +    int ret;
> +
> +    param->sourceWidth = avctx->width;
> +    param->sourceHeight = avctx->height;
> +    param->encoderBitDepth = 8;
> +
> +    if (avctx->pix_fmt == AV_PIX_FMT_YUV420P10LE) {
> +        av_log(avctx, AV_LOG_DEBUG, "Encoder 10 bits depth input\n");
> +
> +        param->encoderBitDepth = 10;
> +    }
> +    param->encoderColorFormat = EB_YUV420;
>
>
this patch blatantly ignores my review(s) and therefore it is rejected

to reiterate:
- if the encoder does not support 10 bit (or if scales down from 10 to 8
internally), this feature should not be present in the wrapper either (or
it should at least warn the user)
- if the encoder does not support setting the color properties in the VUI,
the wrapper should definitely warn the user of the loss of information (or
we should wait until this features is present upstream)

reagrds
-- 
Vittorio