[FFmpeg-devel] [PATCH 0/2] configure: Replace pr with awk and fix column sorting

Alexander Strasser eclipse7 at gmx.net
Wed May 1 19:07:38 EEST 2019


Hi all,

as was discussed in a previous patch set, this is a new try
at getting the output of print_in_columns sorted in correct
alphabetical order. The order with pr is messed up, because
it assumes a page size and therefore breaks columns earlier.

This is also a try to get rid of the pr dependency. There was a
a wish for that in ticket #5680.

I couldn't see a performance hit on my Linux and Windows systems
with the first patch. For the second it depends on the used awk,
where mawk and original awk were roughly in 1% margin, when using
gawk it was around 6% slower. On Windows, it was once 8% slower
on the first run and afterwards I could not reproduce the slowdown
anymore.

ATM I tend to prefer the v5 version from Yejun's patch set
instead of the 2nd patch in this set. For me it's around 1.5%
to 3% faster on Linux and about 5% on Windows, compared to
the current version on master.

I would appreciate more testing, especially on the less
popular platforms.

Alexander Strasser (2):
  configure: print_in_columns: Replace pr with awk
  configure: log_file: Replace pr with awk invocation

 configure | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

--


More information about the ffmpeg-devel mailing list