[FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

Nicolas George george at nsup.org
Thu May 2 12:53:44 EEST 2019


Gyan (12019-04-28):
> b) ffmpeg will call avformat_write_header for the output, which will likely
> fail because of the aforementioned codec parameter issues.

Are you sure? It looks to me like avformat_write_header() does not
perform checks by itself, and null does not either.

> The pipeline for dumping damaged streams is identical to dumping valid
> streams except for the part when timestamps are regulated and codec fields
> validated for the target muxer, which is what my patch disables for a single
> muxer that doesn't need them. I don't see much (any?) "wasted" processing
> with my patch, relative to streamcopying a valid stream.

The problem is not about waste as a performance issue, the problem is
about complexity as a maintenance issue. Exceptions are expensive in
that regard.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190502/dc86aa9b/attachment.sig>


More information about the ffmpeg-devel mailing list