[FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

[Michael Niedermayer]

On Thu, May 02, 2019 at 10:09:23PM +0300, Panagiotis Malakoudis wrote:
> OK, here it is again, attached.
> 
> 
> Στις Πέμ, 2 Μαΐ 2019 στις 9:56 μ.μ., ο/η Carl Eugen Hoyos
> <ceffmpeg at gmail.com> έγραψε:
> >
> > Am Do., 2. Mai 2019 um 20:52 Uhr schrieb Panagiotis Malakoudis
> > <malakudi at gmail.com>:
> > >
> > > > On Thu, May 02, 2019 at 08:13:10PM +0300, Panagiotis Malakoudis wrote:
> >
> > > > > --- libavformat/mpegts.c 2019-04-30 16:11:49.000000000 +0300
> > > > > +++ libavformat/mpegts.c 2019-04-30 18:55:12.736428766 +0300
> > > >
> > > > doesnt apply with git am
> > > > Applying: Using copyts with mpegts output fails after 26, 5 hours
> > > > error: mpegts.c: does not exist in index
> > > > Patch failed at 0001 Using copyts with mpegts output fails after 26, 5 hours
> > > >
> > >
> > > Sorry, it was a simple diff, not a git am compatible diff. Hope I made
> > > it correctly this time:
> >
> > You have to attach it to avoid linebreaks.
> >
> > Carl Eugen
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

>  mpegts.c |   27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 4bef9770af2125d8b3eb5f48bda0fab9e04c7b36  mpegts-33bit-git.patch
> From 5273daaf8e568fc2a2b9a77d91cb8a834b9e14e7 Mon Sep 17 00:00:00 2001
> From: Panagiotis Malakoudis <malakudi at gmail.com>
> Date: Thu, 2 May 2019 21:34:44 +0300
> Subject: [PATCH] Implement smooth 33bit mpegts timestamp overflow in mpegts
>  muxer
> 
> ---
>  libavformat/mpegts.c | 27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)

this will break timestamp handling
not sure what you are trying to do exactly but the way its done is wrong.
There is alot of code that depends on the timestamps from the demuxer
not being mangled like this.

also its the wrong place, timestamp discontinuities are not a thing limited
to mpegts. And there are already layers of attempts to try to do what this
seems to try. Simple rule, if you dont need to allocate memory proportional
to duration in some cases then your code is wrong. Also if you dont intercept
seeks chapters and so on, again the code would be incomplete.

If you want a specific testcase that this breaks. It breaks tbr values
amongth other things for
tickets/2186/multiple_programs.ts

thanks

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190503/5eb58020/attachment.sig>