[FFmpeg-devel] [PATCH] avfilter/xstack: set better error msg for missing layout

Moritz Barsnick barsnick at gmx.net
Tue May 7 15:15:44 EEST 2019


On Tue, May 07, 2019 at 16:26:01 +0530, Gyan wrote:
>      { "inputs", "set number of inputs", OFFSET(nb_inputs), AV_OPT_TYPE_INT, {.i64=2}, 2, INT_MAX, .flags = FLAGS },
> -    { "layout", "set custom layout", OFFSET(layout), AV_OPT_TYPE_STRING, {.str="0_0|w0_0"}, 0, 0, .flags = FLAGS },
> +    { "layout", "set custom layout", OFFSET(layout), AV_OPT_TYPE_STRING, {.str=NULL}, 0, 0, .flags = FLAGS },
>      { "shortest", "force termination when the shortest input terminates", OFFSET(shortest), AV_OPT_TYPE_BOOL, {.i64=0}, 0, 1, .flags = FLAGS },

Because the default is no longer self-documenting ("ffmpeg -h
filter=xstack"), filters.texi should be updated to mention the default.

Cheers,
Moritz


More information about the ffmpeg-devel mailing list