[FFmpeg-devel] [PATCH v9] lavf/flv: Add XV (Xunlei Video) Support. fixes ticket #3720

[Shivam Goyal]

On 11-05-2019 03:21, Reimar Döffinger wrote:

> On 10.05.2019, at 15:10, Shivam Goyal <shivgo at iitk.ac.in> wrote:
> 
>> -> Making two avio contexts and one calling the other ( I am not sure if
>> i implemented it in the right way, but still i reached low level ).
> 
> Can't you at least figure out the header size, decrypt the header and pass that to the normal header parsing code?

  I can get the header size. but the problem is with the first flv
packet. which should be parsed by the flv_read_packet and which is
taking AVFormatContaxt as argument and reads from the file with avio*
functions. 

> Even if not, I'd at least suggest changing the code from reading bytewise and applying rot
> to reading all 8 bytes in a buffer, use a loop to apply rot and then the standard AV_RL functions to read the 32 and 24 bit values.

If i understood correctly, i think this is exactly the same approach
which i already took in decrypting the filled buffer. but the code
become low level because it modifies the buffer, which a demuxer should
not do. 

Thanks for the review 
Shivam Goyal