[FFmpeg-devel] [PATCH 1/2] VP4 video decoder

[Peter Ross]

On Sun, May 12, 2019 at 09:41:40AM +0200, Paul B Mahol wrote:
> On 5/12/19, Peter Ross <pross at xvid.org> wrote:
> > ---
> > i have incorporated all suggestions from the first patch posted jan 2019.
> >
> > if there's nothing further to change, i will apply it a good week or so.
> >
> > cheers,
> >
> >
> >  Changelog               |    1 +
> >  doc/general.texi        |    2 +
> >  libavcodec/allcodecs.c  |    1 +
> >  libavcodec/avcodec.h    |    1 +
> >  libavcodec/codec_desc.c |    7 +
> >  libavcodec/vp3.c        |  718 +++++++-
> >  libavcodec/vp4data.h    | 3784 +++++++++++++++++++++++++++++++++++++++
> >  7 files changed, 4478 insertions(+), 36 deletions(-)
> >  create mode 100644 libavcodec/vp4data.h
> >
> > diff --git a/Changelog b/Changelog
> > index 36a04872fd..8af9006ec0 100644
> > --- a/Changelog
> > +++ b/Changelog
> > @@ -28,6 +28,7 @@ version <next>:
> >  - asoftclip filter
> >  - Support decoding of HEVC 4:4:4 content in vdpau
> >  - colorhold filter
> > +- VP4 video decoder


> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index b749946633..148c63bb89 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -410,6 +410,7 @@ enum AVCodecID {
> >      AV_CODEC_ID_SCREENPRESSO,
> >      AV_CODEC_ID_RSCC,
> >      AV_CODEC_ID_AVS2,
> > +    AV_CODEC_ID_VP4,
> >
> 
> This can not be here.

Fixed.

> > +++ b/libavcodec/vp4data.h
> > @@ -0,0 +1,3784 @@
> > +/*
> > + * Copyright (C) 2019 Peter Ross
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2.1 of the License, or (at your option) any later version.
> > + *

> > +        { 0x19B3, 14 },
> > +        { 0x19B2, 14 },
> > +        {   0x47,  8 },
> > +        {   0x8C,  9 },
> > +        {  0x337, 11 },
> > +        {   0x67,  8 },
> > +        {   0x18,  6 },
> > +        {   0x10,  6 },
> > +        {   0x32,  7 },
> > +        {  0xCD5, 13 },
> > +        {  0xCD4, 13 }
> > +    }
> > +};
> 
> Also those tables takes too much lines.

Agree. It was originally done that way to find patterns from other tables.

I will squish them down.

> 
> Also you need real review.

Every bit helps. Thanks Paul.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190513/4f7e8bc4/attachment.sig>