[FFmpeg-devel] [PATCH] avcodec/decode: Do not output subtitle frames if the packet is marked with `AV_PKT_FLAG_DISCARD`.

Darren Mo fumoboy007 at me.com
Wed May 22 20:55:42 EEST 2019


Good question. The subtitle would be discarded if it overlaps an edit boundary.

The root cause is the MOV demuxer currently marks boundary packets for discard. However, due to subtitle frames not being discarded (fixed by this patch), the root cause is hidden. A potential fix for the root cause would be to handle boundary packets by changing their timestamps to fit the edit boundary. (That would be a separate patch though.)

> On May 22, 2019, at 10:30 AM, Derek Buitenhuis <derek.buitenhuis at gmail.com> wrote:
> 
>> On 29/04/2019 23:45, fumoboy007 wrote:
>> One situation where a subtitle packet can be marked for discard is when demuxing an MOV file that has an edit list.
>> ---
>> libavcodec/decode.c | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
> 
> Will this work properly if a given subtitle overlaps an edit boundary?
> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list